Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix oracle database in field size over 1000 #2973

Merged
merged 5 commits into from
Aug 12, 2020
Merged

bugfix: fix oracle database in field size over 1000 #2973

merged 5 commits into from
Aug 12, 2020

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Aug 4, 2020

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: fix oracle database IN field size over 1000

Ⅱ. Does this pull request fix one issue?

fix #2951

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2020

Codecov Report

Merging #2973 into develop will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2973      +/-   ##
=============================================
+ Coverage      50.26%   50.28%   +0.01%     
- Complexity      3060     3066       +6     
=============================================
  Files            600      600              
  Lines          19507    19514       +7     
  Branches        2404     2408       +4     
=============================================
+ Hits            9806     9813       +7     
  Misses          8715     8715              
  Partials         986      986              
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/rm/datasource/SqlGenerateUtils.java 95.23% <100.00%> (+0.95%) 18.00 <1.00> (+6.00)

@funky-eyes funky-eyes added the module/rm-datasource rm-datasource module label Aug 5, 2020
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass. LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 added this to the 1.4.0 milestone Aug 12, 2020
@l81893521 l81893521 merged commit b4af38e into apache:develop Aug 12, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
igit-cn referenced this pull request in igit-cn/seata May 1, 2021
bugfix: fix oracle database in field size over 1000 (seata#2973)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

事务失败,回滚时镜像校验报错:列表中的最大表达式数为 1000
5 participants