-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: opt globalCommit for mixed use of AT and TCC #2978
optimize: opt globalCommit for mixed use of AT and TCC #2978
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2978 +/- ##
=============================================
- Coverage 50.28% 50.26% -0.03%
- Complexity 3066 3070 +4
=============================================
Files 600 600
Lines 19513 19519 +6
Branches 2408 2410 +2
=============================================
- Hits 9813 9812 -1
- Misses 8714 8721 +7
Partials 986 986
|
…-at-tcc-globalCommit
server/src/main/java/io/seata/server/session/GlobalSession.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
server/src/main/java/io/seata/server/session/GlobalSession.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
optimize: opt globalCommit for mixed use of AT and TCC.
优化混合使用AT和TCC时的全局提交的性能,AT分支越多的全局事务,全局提交的性能提升越大。
优化内容:
在AT和TCC混合使用的情况下,当全局提交时,先提交所有TCC分支,剩余的AT分支再交由
handleAsyncCommitting
异步处理。注:目前只有AT分支支持异步提交。但是在 PR #2981 里,添加了支持TCC分支可自定义为异步提交。
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews