Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: opt globalCommit for mixed use of AT and TCC #2978

Merged

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Aug 5, 2020

Ⅰ. Describe what this PR did

optimize: opt globalCommit for mixed use of AT and TCC.
优化混合使用AT和TCC时的全局提交的性能,AT分支越多的全局事务,全局提交的性能提升越大。

优化内容:

在AT和TCC混合使用的情况下,当全局提交时,先提交所有TCC分支,剩余的AT分支再交由handleAsyncCommitting异步处理。

注:目前只有AT分支支持异步提交。但是在 PR #2981 里,添加了支持TCC分支可自定义为异步提交。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2020

Codecov Report

Merging #2978 into develop will decrease coverage by 0.02%.
The diff coverage is 10.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2978      +/-   ##
=============================================
- Coverage      50.28%   50.26%   -0.03%     
- Complexity      3066     3070       +4     
=============================================
  Files            600      600              
  Lines          19513    19519       +6     
  Branches        2408     2410       +2     
=============================================
- Hits            9813     9812       -1     
- Misses          8714     8721       +7     
  Partials         986      986              
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/BranchSession.java 78.98% <0.00%> (+0.88%) 47.00 <2.00> (+3.00)
...in/java/io/seata/server/session/GlobalSession.java 83.71% <0.00%> (ø) 71.00 <0.00> (ø)
.../java/io/seata/server/coordinator/DefaultCore.java 49.39% <12.50%> (-3.44%) 23.00 <0.00> (ø)

@funky-eyes funky-eyes added this to the 1.4.0 milestone Aug 5, 2020
@funky-eyes funky-eyes added the module/server server module label Aug 5, 2020
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants