Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: columns of resultset integrated with sharingjdbc need to be lowercase #2979

Merged
merged 15 commits into from
Oct 28, 2020

Conversation

yyjgit66
Copy link
Contributor

@yyjgit66 yyjgit66 commented Aug 5, 2020

Ⅰ. Describe what this PR did

Seata and sharding report Can not find columnlabel index_ Name error

Ⅱ. Does this pull request fix one issue?

Can not find columnLabel INDEX_NAME #2975

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

It can be verified by adding, deleting and modifying Seata and sharding

Ⅴ. Special notes for reviews

seata 1.3.0
sharding 4.0.0-RC2
springcloud Hoxton.SR4
springboot 2.3.0.RELEASE
mp 3.2.0

@funky-eyes funky-eyes requested a review from jsbxyyx August 6, 2020 01:29
@yyjgit66 yyjgit66 changed the title Columns of resultset integrated with sharingjdbc need to be lowercase bugfix: Columns of resultset integrated with sharingjdbc need to be lowercase Aug 6, 2020
@funky-eyes funky-eyes added the module/rm-datasource rm-datasource module label Aug 18, 2020
@funky-eyes funky-eyes added this to the 1.4.0 milestone Aug 28, 2020
@@ -465,6 +465,9 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven-surefire-plugin.version}</version>
<configuration>
<skipTests>true</skipTests>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@wangliang181230 wangliang181230 added the type: bug Category issues or prs related to bug. label Oct 23, 2020
@funky-eyes funky-eyes removed this from the 1.4.0 milestone Oct 27, 2020
@slievrly
Copy link
Member

1.4.0-SNAPSHOT
image
image

@slievrly
Copy link
Member

1.3.0
image
image

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix: Columns of resultset integrated with sharingjdbc need to be lowercase bugfix: columns of resultset integrated with sharingjdbc need to be lowercase Oct 28, 2020
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 8895e70 into apache:develop Oct 28, 2020
@slievrly slievrly added this to the 1.4.0 milestone Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants