-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: columns of resultset integrated with sharingjdbc need to be lowercase #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyjgit66
changed the title
Columns of resultset integrated with sharingjdbc need to be lowercase
bugfix: Columns of resultset integrated with sharingjdbc need to be lowercase
Aug 6, 2020
slievrly
reviewed
Oct 10, 2020
@@ -465,6 +465,9 @@ | |||
<groupId>org.apache.maven.plugins</groupId> | |||
<artifactId>maven-surefire-plugin</artifactId> | |||
<version>${maven-surefire-plugin.version}</version> | |||
<configuration> | |||
<skipTests>true</skipTests> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
slievrly
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
slievrly
changed the title
bugfix: Columns of resultset integrated with sharingjdbc need to be lowercase
bugfix: columns of resultset integrated with sharingjdbc need to be lowercase
Oct 28, 2020
l81893521
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Seata and sharding report Can not find columnlabel index_ Name error
Ⅱ. Does this pull request fix one issue?
Can not find columnLabel INDEX_NAME #2975
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
It can be verified by adding, deleting and modifying Seata and sharding
Ⅴ. Special notes for reviews
seata 1.3.0
sharding 4.0.0-RC2
springcloud Hoxton.SR4
springboot 2.3.0.RELEASE
mp 3.2.0