Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix checkstyle plugin can't exclude single file #2986

Merged
merged 1 commit into from
Aug 7, 2020
Merged

bugfix: fix checkstyle plugin can't exclude single file #2986

merged 1 commit into from
Aug 7, 2020

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Aug 6, 2020

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: fix checkstyle plugin can't exclude single file
fixs #2985

http://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-mojo.html#encoding
https://checkstyle.sourceforge.io/config_filters.html

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2020

Codecov Report

Merging #2986 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2986   +/-   ##
==========================================
  Coverage      50.26%   50.26%           
  Complexity      3060     3060           
==========================================
  Files            600      600           
  Lines          19507    19507           
  Branches        2404     2404           
==========================================
  Hits            9806     9806           
  Misses          8715     8715           
  Partials         986      986           
Impacted Files Coverage Δ Complexity Δ
...io/seata/core/rpc/netty/RmNettyRemotingClient.java 39.13% <100.00%> (ø) 10.00 <1.00> (ø)
...io/seata/core/rpc/netty/TmNettyRemotingClient.java 66.10% <100.00%> (ø) 10.00 <1.00> (ø)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit af42560 into apache:develop Aug 7, 2020
@funky-eyes funky-eyes added this to the 1.4.0 milestone Sep 21, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants