Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the wrong package path #3025

Merged
merged 5 commits into from
Aug 24, 2020
Merged

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

fix the wrong package path

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2020

Codecov Report

Merging #3025 into develop will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3025      +/-   ##
=============================================
+ Coverage      50.26%   50.38%   +0.12%     
- Complexity      3068     3090      +22     
=============================================
  Files            600      600              
  Lines          19518    19518              
  Branches        2410     2410              
=============================================
+ Hits            9811     9835      +24     
+ Misses          8720     8697      -23     
+ Partials         987      986       -1     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/GlobalSession.java 83.71% <0.00%> (+0.45%) 71.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 55.15% <0.00%> (+0.51%) 29.00% <0.00%> (+1.00%)
...ta/core/store/db/sql/lock/LockStoreSqlFactory.java 66.66% <0.00%> (+66.66%) 2.00% <0.00%> (+2.00%)
...a/core/store/db/sql/lock/AbstractLockStoreSql.java 88.88% <0.00%> (+88.88%) 8.00% <0.00%> (+8.00%)
...o/seata/core/store/db/sql/lock/H2LockStoreSql.java 100.00% <0.00%> (+100.00%) 2.00% <0.00%> (+2.00%)
...eata/core/store/db/sql/lock/MysqlLockStoreSql.java 100.00% <0.00%> (+100.00%) 2.00% <0.00%> (+2.00%)
...ata/core/store/db/sql/lock/OracleLockStoreSql.java 100.00% <0.00%> (+100.00%) 2.00% <0.00%> (+2.00%)
.../core/store/db/sql/lock/OceanbaseLockStoreSql.java 100.00% <0.00%> (+100.00%) 2.00% <0.00%> (+2.00%)
...core/store/db/sql/lock/PostgresqlLockStoreSql.java 100.00% <0.00%> (+100.00%) 2.00% <0.00%> (+2.00%)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.4.0 milestone Aug 24, 2020
@funky-eyes funky-eyes added the module/core core module label Aug 24, 2020
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @wangliang181230

@l81893521 l81893521 merged commit 46d9c19 into apache:develop Aug 24, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/core core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants