Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: fix fetch before images when delete and update statements #3050

Merged
merged 32 commits into from
Oct 10, 2020
Merged

bugfix: fix fetch before images when delete and update statements #3050

merged 32 commits into from
Oct 10, 2020

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Aug 21, 2020 •
edited

Ⅰ. Describe what this PR did

incorrect fetching of pre-images when deleting statements

Ⅱ. Does this pull request fix one issue?

fixes #3048 #2805

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020 •
edited

Codecov Report

Merging #3050 into develop will increase coverage by 0.04%.
The diff coverage is 67.21%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3050      +/-   ##
=============================================
+ Coverage      50.37%   50.42%   +0.04%     
- Complexity      3116     3128      +12     
=============================================
  Files            594      594              
  Lines          19625    19678      +53     
  Branches        2438     2452      +14     
=============================================
+ Hits            9887     9923      +36     
- Misses          8744     8752       +8     
- Partials         994     1003       +9
Impacted Files Coverage Δ Complexity Δ
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 75.60% <ø> (ø) 9.00 <0.00> (ø)
...er/druid/mysql/MySQLSelectForUpdateRecognizer.java 100.00% <ø> (ø) 9.00 <0.00> (ø)
...a/sqlparser/druid/mysql/MySQLUpdateRecognizer.java 93.02% <0.00%> (-4.54%) 14.00 <0.00> (ø)
...sqlparser/druid/oracle/OracleDeleteRecognizer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../druid/oracle/OracleSelectForUpdateRecognizer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...sqlparser/druid/oracle/OracleUpdateRecognizer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...va/io/seata/rm/datasource/exec/DeleteExecutor.java 83.33% <42.85%> (-16.67%) 6.00 <0.00> (ø)
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 77.04% <42.85%> (-4.77%) 11.00 <0.00> (ø)
.../rm/datasource/exec/BaseTransactionalExecutor.java 58.13% <50.00%> (ø) 27.00 <2.00> (ø)
...ata/sqlparser/druid/mysql/BaseMySQLRecognizer.java 84.48% <81.08%> (-6.00%) 14.00 <8.00> (+8.00) ⬇️
... and 1 more

@funky-eyes funky-eyes added this to the 1.4.0 milestone Aug 28, 2020
@funky-eyes funky-eyes added the module/rm-datasource rm-datasource module label Aug 28, 2020
@funky-eyes funky-eyes changed the title bugfix：incorrect fetching of pre-images when deleting statements bugfix：incorrect fetching of pre-images when delete and update statements Sep 23, 2020
caohdgege
caohdgege approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

slievrly
slievrly approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Oct 10, 2020 •
edited

Codecov Report

Merging #3050 into develop will increase coverage by 0.03%.
The diff coverage is 67.21%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3050      +/-   ##
=============================================
+ Coverage      50.38%   50.41%   +0.03%     
- Complexity      3118     3124       +6     
=============================================
  Files            594      594              
  Lines          19632    19685      +53     
  Branches        2441     2457      +16     
=============================================
+ Hits            9891     9925      +34     
- Misses          8747     8755       +8     
- Partials         994     1005      +11
Impacted Files Coverage Δ Complexity Δ
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 75.60% <ø> (ø) 9.00 <0.00> (ø)
...er/druid/mysql/MySQLSelectForUpdateRecognizer.java 100.00% <ø> (ø) 9.00 <0.00> (ø)
...a/sqlparser/druid/mysql/MySQLUpdateRecognizer.java 93.02% <0.00%> (-4.54%) 14.00 <0.00> (ø)
...sqlparser/druid/oracle/OracleDeleteRecognizer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../druid/oracle/OracleSelectForUpdateRecognizer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...sqlparser/druid/oracle/OracleUpdateRecognizer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...va/io/seata/rm/datasource/exec/DeleteExecutor.java 83.33% <42.85%> (-16.67%) 6.00 <0.00> (ø)
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 77.04% <42.85%> (-4.77%) 11.00 <0.00> (ø)
.../rm/datasource/exec/BaseTransactionalExecutor.java 58.13% <50.00%> (ø) 27.00 <2.00> (ø)
...ata/sqlparser/druid/mysql/BaseMySQLRecognizer.java 84.48% <81.08%> (-6.00%) 14.00 <8.00> (+8.00) ⬇️
... and 3 more

l81893521
l81893521 approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix：incorrect fetching of pre-images when delete and update statements bugfix：fix fetch before images when delete and update statements Oct 10, 2020
@slievrly slievrly changed the title bugfix：fix fetch before images when delete and update statements bugfix: fix fetch before images when delete and update statements Oct 10, 2020
@slievrly slievrly merged commit b5e545b into apache:develop Oct 10, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
@funky-eyes @l81893521
bugfix: fix fetch before images when delete and update statements (ap…
92a9751 
…ache#3050)
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
@funky-eyes @hicf
bugfix: fix fetch before images when delete and update statements (ap…
ea4cdf1 
…ache#3050)
@snyk-bot snyk-bot mentioned this pull request Jan 13, 2022
Open
This was referenced Feb 10, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l81893521 l81893521 l81893521 approved these changes

@slievrly slievrly slievrly approved these changes

@caohdgege caohdgege caohdgege approved these changes

@jsbxyyx jsbxyyx Awaiting requested review from jsbxyyx

Assignees
No one assigned
Labels
module/rm-datasource rm-datasource module
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

DeleteExecutor should build "after image" according to the DB
6 participants
@funky-eyes @codecov-commenter @codecov-io @l81893521 @slievrly @caohdgege