-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: jedis pool adds maxtotal configuration #3053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3053 +/- ##
=============================================
- Coverage 50.37% 50.36% -0.01%
Complexity 3088 3088
=============================================
Files 600 600
Lines 19519 19520 +1
Branches 2411 2411
=============================================
Hits 9832 9832
- Misses 8698 8699 +1
Partials 989 989
|
funky-eyes
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
标题前缀加一下 |
yujianfei1986
changed the title
jedis pool adds maxtotal configuration
feature:jedis pool adds maxtotal configuration
Aug 24, 2020
yujianfei1986
changed the title
feature:jedis pool adds maxtotal configuration
feature: jedis pool adds maxtotal configuration
Aug 24, 2020
yujianfei1986
changed the title
feature: jedis pool adds maxtotal configuration
optimize: jedis pool adds maxtotal configuration
Aug 24, 2020
l81893521
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Oct 22, 2020
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
jedis连接池增加maxTotal配置项,可以设置与redis的最大连接数
Ⅱ. Does this pull request fix one issue?
否
Ⅲ. Why don't you add test cases (unit test/integration test)?
不涉及
Ⅳ. Describe how to verify it
可以在压测过程中,观察redis客户端的连接数,如果不加此配置,默认jedis与redis的链接是8;通过配置可以
增加与redis的连接数,从而提供性能
Ⅴ. Special notes for reviews
jedis连接池增加maxtotal参数配置