Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: jedis pool adds maxtotal configuration #3053

Merged
merged 3 commits into from
Aug 25, 2020

Conversation

yujianfei1986
Copy link
Contributor

Ⅰ. Describe what this PR did

jedis连接池增加maxTotal配置项,可以设置与redis的最大连接数

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

不涉及

Ⅳ. Describe how to verify it

可以在压测过程中,观察redis客户端的连接数,如果不加此配置,默认jedis与redis的链接是8;通过配置可以
增加与redis的连接数,从而提供性能

Ⅴ. Special notes for reviews

jedis连接池增加maxtotal参数配置

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2020

Codecov Report

Merging #3053 into develop will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3053      +/-   ##
=============================================
- Coverage      50.37%   50.36%   -0.01%     
  Complexity      3088     3088              
=============================================
  Files            600      600              
  Lines          19519    19520       +1     
  Branches        2411     2411              
=============================================
  Hits            9832     9832              
- Misses          8698     8699       +1     
  Partials         989      989              
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...seata/server/storage/redis/JedisPooledFactory.java 40.00% <0.00%> (-1.67%) 4.00 <0.00> (ø)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added module/server server module TC/store store mode labels Aug 24, 2020
@funky-eyes
Copy link
Contributor

标题前缀加一下

@yujianfei1986 yujianfei1986 changed the title jedis pool adds maxtotal configuration feature:jedis pool adds maxtotal configuration Aug 24, 2020
@yujianfei1986 yujianfei1986 changed the title feature:jedis pool adds maxtotal configuration feature: jedis pool adds maxtotal configuration Aug 24, 2020
@yujianfei1986 yujianfei1986 changed the title feature: jedis pool adds maxtotal configuration optimize: jedis pool adds maxtotal configuration Aug 24, 2020
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 added this to the 1.4.0 milestone Aug 25, 2020
@l81893521 l81893521 merged commit 1b81024 into apache:develop Aug 25, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module TC/store store mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants