-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: part of the connection is not unpacked #3071
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3071 +/- ##
=============================================
- Coverage 50.56% 50.55% -0.02%
+ Complexity 3102 3101 -1
=============================================
Files 599 599
Lines 19516 19514 -2
Branches 2405 2404 -1
=============================================
- Hits 9868 9865 -3
Misses 8657 8657
- Partials 991 992 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
很多数据库连接池框架的连接并没有实现过PooledConnection,很是奇怪。Hikari就是没实现过PooledConnection。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
connection 为com.alibaba.druid.proxy.jdbc.ConnectionProxyImpl
如果创建druid连接池时加入了Filter就会变成由ConnectionProxyImpl来实现connection
例如:
此时datasourcexa中的getconnection获取到的connection是无法创建xaconnection
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews