Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: do not proxy connections without an xid #3073

Merged
merged 8 commits into from
Sep 15, 2020

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Aug 31, 2020

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #3072

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes changed the title do not proxy connections without an XID bugfix: do not proxy connections without an xid Aug 31, 2020
@funky-eyes funky-eyes added this to the 1.4.0 milestone Aug 31, 2020
@funky-eyes funky-eyes added the module/rm-datasource rm-datasource module label Aug 31, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2020

Codecov Report

Merging #3073 into develop will decrease coverage by 0.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3073      +/-   ##
=============================================
- Coverage      50.58%   50.57%   -0.02%     
  Complexity      3103     3103              
=============================================
  Files            599      599              
  Lines          19504    19510       +6     
  Branches        2407     2407              
=============================================
+ Hits            9867     9868       +1     
- Misses          8647     8650       +3     
- Partials         990      992       +2     
Impacted Files Coverage Δ Complexity Δ
...ta/rm/datasource/xa/AbstractDataSourceProxyXA.java 7.69% <0.00%> (ø) 1.00 <0.00> (ø)
...eata/rm/datasource/xa/DataSourceProxyXANative.java 72.22% <0.00%> (-4.25%) 4.00 <0.00> (ø)
...a/io/seata/rm/datasource/xa/DataSourceProxyXA.java 80.95% <60.00%> (-6.55%) 6.00 <2.00> (+2.00) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 82.43% <0.00%> (-0.46%) 70.00% <0.00%> (-1.00%)

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @wangliang181230

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 191cdb2 into apache:develop Sep 15, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用XA模式时,没有启动全局事务也会自动进行代理
5 participants