-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: do not proxy connections without an xid #3073
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3073 +/- ##
=============================================
- Coverage 50.58% 50.57% -0.02%
Complexity 3103 3103
=============================================
Files 599 599
Lines 19504 19510 +6
Branches 2407 2407
=============================================
+ Hits 9867 9868 +1
- Misses 8647 8650 +3
- Partials 990 992 +2
|
rm-datasource/src/main/java/io/seata/rm/datasource/xa/DataSourceProxyXA.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for @wangliang181230
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #3072
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews