Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: There is no need to retry if the XA schema cannot find the XID #3074

Merged
merged 4 commits into from
Sep 15, 2020

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

xa分支事务如果已经做了commit,此时宕机,tc会继续发出提交此分支事务的指令,而因为xa分支已经提交,就会抛出找不到该xid的异常,无论是rollback还是commit,如果是找不到,说明此分支事务已经被处理,无需再次处理

Ⅱ. Does this pull request fix one issue?

fixes #2971

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #3074 into develop will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3074      +/-   ##
=============================================
- Coverage      50.59%   50.57%   -0.02%     
- Complexity      3101     3102       +1     
=============================================
  Files            599      599              
  Lines          19499    19504       +5     
  Branches        2404     2407       +3     
=============================================
  Hits            9865     9865              
- Misses          8642     8647       +5     
  Partials         992      992              
Impacted Files Coverage Δ Complexity Δ
...a/io/seata/rm/datasource/xa/ResourceManagerXA.java 15.15% <0.00%> (-2.71%) 4.00 <0.00> (ø)

@funky-eyes funky-eyes added module/rm rm module module/rm-datasource rm-datasource module and removed module/rm rm module labels Sep 1, 2020
@funky-eyes funky-eyes added this to the 1.4.0 milestone Sep 1, 2020
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @wangliang181230

@slievrly slievrly merged commit 1bf26f7 into apache:develop Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XA模式下数据一致性问题
5 participants