-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: There is no need to retry if the XA schema cannot find the XID #3074
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3074 +/- ##
=============================================
- Coverage 50.59% 50.57% -0.02%
- Complexity 3101 3102 +1
=============================================
Files 599 599
Lines 19499 19504 +5
Branches 2404 2407 +3
=============================================
Hits 9865 9865
- Misses 8642 8647 +5
Partials 992 992
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for @wangliang181230
Ⅰ. Describe what this PR did
xa分支事务如果已经做了commit,此时宕机,tc会继续发出提交此分支事务的指令,而因为xa分支已经提交,就会抛出找不到该xid的异常,无论是rollback还是commit,如果是找不到,说明此分支事务已经被处理,无需再次处理
Ⅱ. Does this pull request fix one issue?
fixes #2971
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews