-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix HttpAutoConfiguration always instantiation in springboot env #3097
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3097 +/- ##
=============================================
+ Coverage 50.56% 50.60% +0.03%
Complexity 3101 3101
=============================================
Files 599 599
Lines 19514 19498 -16
Branches 2404 2404
=============================================
- Hits 9867 9866 -1
+ Misses 8656 8641 -15
Partials 991 991
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM please add test case for HttpCondition
springboot有提供 |
修改了实现方式: |
@l81893521 @a364176773 @wangliang181230 麻烦review一下,或者有其他的改进建议吗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for @wangliang181230
Ⅰ. Describe what this PR did
fix HttpAutoConfiguration always instantiation in springboot env
Ⅱ. Does this pull request fix one issue?
fixes #3095
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews