-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: Add more configuration tips in additional-spring-configuration-metadata.json
#3118
Merged
slievrly
merged 5 commits into
apache:develop
from
wangliang181230:optimize-simplify-config-1
Sep 18, 2020
Merged
optimize: Add more configuration tips in additional-spring-configuration-metadata.json
#3118
slievrly
merged 5 commits into
apache:develop
from
wangliang181230:optimize-simplify-config-1
Sep 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3118 +/- ##
=============================================
+ Coverage 50.58% 50.63% +0.05%
+ Complexity 3105 3103 -2
=============================================
Files 599 593 -6
Lines 19514 19495 -19
Branches 2408 2406 -2
=============================================
+ Hits 9871 9872 +1
+ Misses 8651 8633 -18
+ Partials 992 990 -2
|
funky-eyes
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
slievrly
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
wangliang181230
added
theme: experience
type: optimize
module/seata-spring-boot-starter
seata-spring-boot-starter module
labels
Oct 19, 2020
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Oct 22, 2020
…tion-metadata.json` (apache#3118)
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
…tion-metadata.json` (apache#3118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize: Add more configuration tips in
additional-spring-configuration-metadata.json
.优化:添加更多配置提示信息到
additional-spring-configuration-metadata.json
中。在springboot项目的yaml配置文件里,编写配置时,将会有提示信息,部分配置还有可选值提示。非常方便。
注:此PR是从 #2964 中拆分出来的。
顺便优化以下内容
WorkThreadMode.getModeByName(String name)
方法。Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews