Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: Add more configuration tips in additional-spring-configuration-metadata.json #3118

Merged
merged 5 commits into from
Sep 18, 2020

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Sep 16, 2020

Ⅰ. Describe what this PR did

optimize: Add more configuration tips in additional-spring-configuration-metadata.json.
优化:添加更多配置提示信息到additional-spring-configuration-metadata.json中。
在springboot项目的yaml配置文件里,编写配置时,将会有提示信息,部分配置还有可选值提示。非常方便。

注:此PR是从 #2964 中拆分出来的。

顺便优化以下内容

  1. 将常量类由类变更为接口,使代码看起来更简单。(无任何常量值或功能变更)
  2. 优化WorkThreadMode.getModeByName(String name)方法。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2020

Codecov Report

Merging #3118 into develop will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3118      +/-   ##
=============================================
+ Coverage      50.58%   50.63%   +0.05%     
+ Complexity      3105     3103       -2     
=============================================
  Files            599      593       -6     
  Lines          19514    19495      -19     
  Branches        2408     2406       -2     
=============================================
+ Hits            9871     9872       +1     
+ Misses          8651     8633      -18     
+ Partials         992      990       -2     
Impacted Files Coverage Δ Complexity Δ
...n/src/main/java/io/seata/common/DefaultValues.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/io/seata/core/constants/ConfigurationKeys.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/io/seata/core/protocol/ProtocolConstants.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ta/integration/grpc/interceptor/GrpcHeaderKey.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ommon/src/main/java/io/seata/common/Constants.java 100.00% <100.00%> (+50.00%) 1.00 <1.00> (ø)
.../java/io/seata/core/rpc/netty/NettyBaseConfig.java 43.28% <100.00%> (+7.17%) 2.00 <0.00> (ø)
.../io/seata/rm/datasource/undo/UndoLogConstants.java 100.00% <100.00%> (+33.33%) 1.00 <1.00> (ø)
...ta/spring/boot/autoconfigure/StarterConstants.java 100.00% <100.00%> (+3.70%) 1.00 <1.00> (ø)
...java/io/seata/server/metrics/MeterIdConstants.java 100.00% <100.00%> (+3.44%) 1.00 <1.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)
... and 1 more

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lightClouds917
Copy link
Contributor

LGTM

@slievrly slievrly merged commit 929c817 into apache:develop Sep 18, 2020
@wangliang181230 wangliang181230 deleted the optimize-simplify-config-1 branch September 18, 2020 09:33
@l81893521 l81893521 added this to the 1.4.0 milestone Sep 18, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants