bugfix: forbidding execute SQL which update pk value #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3129 +/- ##
=============================================
+ Coverage 50.58% 50.61% +0.02%
- Complexity 3105 3108 +3
=============================================
Files 599 599
Lines 19514 19521 +7
Branches 2408 2409 +1
=============================================
+ Hits 9871 9880 +9
+ Misses 8651 8649 -2
Partials 992 992
|
funky-eyes
requested review from
jsbxyyx and
l81893521
and removed request for
jsbxyyx
Codecov Report
@@ Coverage Diff @@
## develop #3129 +/- ##
=============================================
+ Coverage 50.40% 50.43% +0.03%
- Complexity 3124 3129 +5
=============================================
Files 594 594
Lines 19700 19707 +7
Branches 2460 2461 +1
=============================================
+ Hits 9929 9939 +10
+ Misses 8766 8765 -1
+ Partials 1005 1003 -2
|
jsbxyyx
reviewed
Oct 10, 2020
| @@ -172,4 +173,13 @@ public static boolean isLockRetryPolicyBranchRollbackOnConflict() { | |||
| return LOCK_RETRY_POLICY_BRANCH_ROLLBACK_ON_CONFLICT; | |||
| } | |||
| } | |||
|
|
|||
| protected void isUpdatePkValue(List<String> updateColumns) { | |||
There was a problem hiding this comment.
return boolean? control of exception by caller?
There was a problem hiding this comment.
I think this is unnecessary. It just checks if the param is legal. There is nothing to control by the caller.
There was a problem hiding this comment.
this method is more suitable placed in UpdateExecutor or MultiUpdateExecutor. or rename method name.
There was a problem hiding this comment.
What method name do you want? Please give me some advice
There was a problem hiding this comment.
how about assertContainsPKColumnName?
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseInsertExecutor.java
l81893521
changed the title
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Forbidding execute SQL which updates pk value.
Ⅱ. Does this pull request fix one issue?
#3066
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews