-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix some problems in the automatic data source proxy #3130
Merged
xingfudeshi
merged 16 commits into
apache:develop
from
wangliang181230:optimize-data-source-proxy
Oct 1, 2020
Merged
bugfix: fix some problems in the automatic data source proxy #3130
xingfudeshi
merged 16 commits into
apache:develop
from
wangliang181230:optimize-data-source-proxy
Oct 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3130 +/- ##
=============================================
- Coverage 50.46% 50.36% -0.10%
- Complexity 3111 3114 +3
=============================================
Files 593 594 +1
Lines 19571 19625 +54
Branches 2427 2438 +11
=============================================
+ Hits 9876 9885 +9
- Misses 8702 8744 +42
- Partials 993 996 +3
|
funky-eyes
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wangliang181230
changed the title
optimize: opt the logic of executing data source proxy
bugfix: fixed some errors in the automatic data source proxy
Sep 30, 2020
wangliang181230
changed the title
bugfix: fixed some errors in the automatic data source proxy
bugfix: fixed some problems in the automatic data source proxy
Sep 30, 2020
wangliang181230
changed the title
bugfix: fixed some problems in the automatic data source proxy
bugfix: fix some problems in the automatic data source proxy
Sep 30, 2020
@xingfudeshi 这个PR从解决死锁BUG的PR里拆分出来了。麻烦Review一下。 |
xingfudeshi
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
1 task
1 task
wangliang181230
added
mode: AT
AT transaction mode
mode: XA
XA transaction mode
module/rm-datasource
rm-datasource module
type: bug
Category issues or prs related to bug.
labels
Oct 19, 2020
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Oct 22, 2020
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mode: AT
AT transaction mode
mode: XA
XA transaction mode
module/rm-datasource
rm-datasource module
type: bug
Category issues or prs related to bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
bugfix: fixed some problems in the automatic data source proxy.
修复自动数据源代理的一些问题,用户使用体验会更好,与第三方组件的兼容性也会更好。
注:从此PR是从 #2879 中拆分出来的。
此PR调整的内容:
AT
/XA
代理类构造函数中解除代理,避免用户手动创建代理导致双重代理所致的各种未知问题;(借用了大佬 @slievrly 的PR optimize: optimize datasource proxy #2921 的代码,主要我这边新增了一个接口SeataDataSourceProxy
)AT
/XA
代理时,不进入代理类的方法,而是直接执行原来的DataSource
的功能,避免一些不可预测的问题,增强seata
与其他第三方组件的兼容性。AT
/XA
在项目启动时未注册资源的问题了。@EnableAutoDataSourceProxy
启用XA模式时,RootContext.DEFAULT_BRANCH_TYPE
的值却为AT
的BUG。Ⅱ. Does this pull request fix one issue?
fixes #2857
fixes #3060
解决了 issue #2857 里的其中一种死锁的情况。
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews