Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:the redis pipeline #3136

Merged
merged 3 commits into from
Sep 23, 2020
Merged

bugfix:the redis pipeline #3136

merged 3 commits into from
Sep 23, 2020

Conversation

lightClouds917
Copy link
Contributor

Ⅰ. Describe what this PR did

fix:the redis pipeline

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2020

Codecov Report

Merging #3136 into develop will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3136      +/-   ##
=============================================
- Coverage      56.29%   56.18%   -0.11%     
+ Complexity       562      559       -3     
=============================================
  Files             57       57              
  Lines           3457     3458       +1     
  Branches         423      423              
=============================================
- Hits            1946     1943       -3     
- Misses          1260     1262       +2     
- Partials         251      253       +2     
Impacted Files Coverage Δ Complexity Δ
...rage/redis/store/RedisTransactionStoreManager.java 36.36% <100.00%> (+0.30%) 20.00 <0.00> (ø)
...erver/storage/file/session/FileSessionManager.java 61.66% <0.00%> (-2.50%) 27.00% <0.00%> (-1.00%)
.../java/io/seata/server/coordinator/DefaultCore.java 49.39% <0.00%> (-0.61%) 23.00% <0.00%> (-1.00%)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added Do Not Merge Do not merge into develop module/server server module TC/store store mode labels Sep 22, 2020
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @caohdgege

@l81893521 l81893521 added this to the 1.4.0 milestone Sep 23, 2020
@funky-eyes funky-eyes removed the Do Not Merge Do not merge into develop label Sep 23, 2020
@funky-eyes funky-eyes merged commit 78ccadb into apache:develop Sep 23, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
@funky-eyes funky-eyes changed the title fix:the redis pipeline bugfix:the redis pipeline Oct 23, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module TC/store store mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants