Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: Upgrade nacos and FastJSON dependencies #3141

Merged
merged 2 commits into from
Sep 23, 2020

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Sep 22, 2020

Ⅰ. Describe what this PR did

seata-server需要fastjson做redis的序列化,原先server内的fastjson由nacos-client依赖引入,目前已经被移除,得单独引入

Ⅱ. Does this pull request fix one issue?

fixes #3138

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 1.4.0 milestone Sep 22, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020

Codecov Report

Merging #3141 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3141   +/-   ##
==========================================
  Coverage      56.17%   56.17%           
  Complexity       559      559           
==========================================
  Files             57       57           
  Lines           3457     3457           
  Branches         423      423           
==========================================
  Hits            1942     1942           
  Misses          1262     1262           
  Partials         253      253           

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 504e7d4 into apache:develop Sep 23, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NacosException "status":403,"error":"Forbidden","message":"unknown user!"
4 participants