optimize: remove repeated conditional tests (#3161) #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3162 +/- ##
=============================================
- Coverage 50.36% 50.27% -0.10%
- Complexity 3114 3117 +3
=============================================
Files 594 594
Lines 19625 19603 -22
Branches 2438 2393 -45
=============================================
- Hits 9885 9856 -29
+ Misses 8744 8731 -13
- Partials 996 1016 +20 |
caohdgege
reviewed
Sep 29, 2020
| @@ -156,6 +155,12 @@ | |||
| } | |||
|
|
|||
| public static Map<String, String> convert(Map<String, Object> param) { | |||
| return param.keySet().stream().filter(key -> param.get(key) != null && param.get(key) != null).collect(Collectors.toMap(key -> key, key -> param.get(key).toString())); | |||
| Map<String, String> covertMap = new HashMap<>(); | |||
There was a problem hiding this comment.
recommend move this method to io.seata.common.util.CollectionUtils and make a appropriate method name?
建议把这个方法移动到 io.seata.common.util.CollectionUtils，然后起个更合理的名字。
caohdgege
reviewed
Sep 29, 2020
| Map<String, String> covertMap = new HashMap<>(); | ||
| param.forEach((key, value) -> { | ||
| if (value != null) { | ||
| covertMap.put(key, value.toString()); |
There was a problem hiding this comment.
recommend StringUtils.objectToString instead of value.toString()
建议StringUtils.objectToString替代value.toString
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Oct 22, 2020
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
1.remove Repeated conditional tests
2.keySet().stream()->map.foreach
Ⅱ. Does this pull request fix one issue?
fixes #3161
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews