Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove duplicated in string utils #3186

Merged
merged 1 commit into from
Oct 14, 2020
Merged

optimize: remove duplicated in string utils #3186

merged 1 commit into from
Oct 14, 2020

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Oct 13, 2020

Ⅰ. Describe what this PR did

optimize: string utils isBlank method.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 changed the title optimize: string utils optimize: remove duplicated in string utils Oct 14, 2020
@l81893521 l81893521 merged commit b80fa9f into apache:develop Oct 14, 2020
@jsbxyyx jsbxyyx deleted the optimize_util branch October 15, 2020 10:14
@wangliang181230 wangliang181230 added this to the 1.4.0 milestone Oct 19, 2020
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants