Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: support jdbc type nclob #3191

Merged
merged 9 commits into from
Oct 20, 2020
Merged

feature: support jdbc type nclob #3191

merged 9 commits into from
Oct 20, 2020

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Oct 15, 2020

Ⅰ. Describe what this PR did

feat: support jdbc 4.0 nclob type.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Oct 15, 2020 •
edited

Codecov Report

Merging #3191 into develop will decrease coverage by 0.05%.
The diff coverage is 20.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3191      +/-   ##
=============================================
- Coverage      50.57%   50.52%   -0.06%     
+ Complexity      3161     3142      -19     
=============================================
  Files            598      598              
  Lines          19702    19777      +75     
  Branches        2443     2467      +24     
=============================================
+ Hits            9965     9992      +27     
- Misses          8749     8783      +34     
- Partials         988     1002      +14
Impacted Files Coverage Δ Complexity Δ
...o/seata/rm/datasource/sql/struct/TableRecords.java 75.00% <20.00%> (-3.41%) 21.00 <0.00> (ø)
...ata/core/store/db/sql/log/LogStoreSqlsFactory.java 57.14% <0.00%> (-17.86%) 2.00% <0.00%> (-1.00%)
...eata/rm/datasource/undo/UndoLogManagerFactory.java 57.14% <0.00%> (-17.86%) 2.00% <0.00%> (-1.00%)
...arser/druid/SQLOperateRecognizerHolderFactory.java 57.14% <0.00%> (-17.86%) 2.00% <0.00%> (-1.00%)
...seata/rm/datasource/undo/UndoLogParserFactory.java 83.33% <0.00%> (-16.67%) 3.00% <0.00%> (-1.00%)
...seata/saga/statelang/parser/JsonParserFactory.java 90.00% <0.00%> (-10.00%) 3.00% <0.00%> (ø%)
...ta/core/store/db/sql/lock/LockStoreSqlFactory.java 66.66% <0.00%> (-8.34%) 2.00% <0.00%> (-1.00%)
...io/seata/saga/proctrl/impl/ProcessContextImpl.java 26.41% <0.00%> (-2.16%) 9.00% <0.00%> (ø%)
...rc/main/java/io/seata/common/util/StringUtils.java 14.40% <0.00%> (-1.55%) 8.00% <0.00%> (+1.00%) ⬇️
.../statelang/parser/impl/StateMachineParserImpl.java 62.74% <0.00%> (-1.26%) 8.00% <0.00%> (ø%)
... and 39 more

@wangliang181230 wangliang181230 changed the title feat: support jdbc type nclob feature: support jdbc type nclob Oct 16, 2020
@wangliang181230 wangliang181230 added module/rm-datasource rm-datasource module mode: AT AT transaction mode and removed module/rm-datasource rm-datasource module labels Oct 16, 2020
slievrly
slievrly approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

funky-eyes
funky-eyes approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.4.0 milestone Oct 20, 2020
l81893521
l81893521 approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 4292134 into apache:develop Oct 20, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
@jsbxyyx @hicf
feature: support jdbc type nclob (apache#3191)
fd57c51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l81893521 l81893521 l81893521 approved these changes

@slievrly slievrly slievrly approved these changes

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees
No one assigned
Labels
mode: AT AT transaction mode module/rm-datasource rm-datasource module
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jsbxyyx @codecov-io @l81893521 @slievrly @funky-eyes @wangliang181230