Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: spring boot support for custom config and registry type #3198

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

JRial95
Copy link
Contributor

@JRial95 JRial95 commented Oct 15, 2020

Ⅰ. Describe what this PR did

Add the Spring Boot support for custom config and registry type

Ⅱ. Does this pull request fix one issue?

Fixes #3196.

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes
Copy link
Contributor

are you currently sure you can use Custom Config and Registy?

@JRial95
Copy link
Contributor Author

JRial95 commented Oct 15, 2020

Yes, it works for the custom registry. Here is a minimal example.
However, I have not tested the custom config.

@JRial95
Copy link
Contributor Author

JRial95 commented Oct 15, 2020

I have updated my example. The custom config also works.

@funky-eyes
Copy link
Contributor

funky-eyes commented Oct 15, 2020 via email

@funky-eyes funky-eyes added the module/config config module label Oct 16, 2020
@funky-eyes
Copy link
Contributor

`registry {
type = "custom"

custom {
name = "MyCustomRegistry"
}
} `

This is possible as long as your dependency is seata-all

@wangliang181230 wangliang181230 added the module/registry registry module label Oct 16, 2020
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added the first-time contributor first-time contributor label Oct 16, 2020
@wangliang181230
Copy link
Contributor

Please add configuration information to the configuration file in /script/client

@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #3198 into develop will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3198   +/-   ##
==========================================
  Coverage      50.50%   50.51%           
- Complexity      3135     3139    +4     
==========================================
  Files            596      598    +2     
  Lines          19761    19773   +12     
  Branches        2465     2465           
==========================================
+ Hits            9980     9988    +8     
- Misses          8777     8781    +4     
  Partials        1004     1004           
Impacted Files Coverage Δ Complexity Δ
...gure/properties/config/ConfigCustomProperties.java 60.00% <60.00%> (ø) 2.00 <2.00> (?)
.../properties/registry/RegistryCustomProperties.java 60.00% <60.00%> (ø) 2.00 <2.00> (?)
...ta/spring/boot/autoconfigure/StarterConstants.java 100.00% <100.00%> (ø) 1.00 <0.00> (ø)

@JRial95
Copy link
Contributor Author

JRial95 commented Oct 16, 2020

@wangliang181230 Configuration information added to the configuration file in /script/client

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230 wangliang181230 merged commit ad65662 into apache:develop Oct 16, 2020
@wangliang181230 wangliang181230 added this to the 1.4.0 milestone Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/config config module module/registry registry module theme: config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring Boot support for custom config and registry type
4 participants