-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: spring boot support for custom config and registry type #3198
Conversation
are you currently sure you can use Custom Config and Registy? |
Yes, it works for the custom registry. Here is a minimal example. |
I have updated my example. The custom config also works. |
thx. good job------------------ 原始邮件 ------------------
发件人: "Jonathan&nbsp;Rial"<notifications@github.com>
发送时间: 2020年10月15日(星期四) 晚上11:53
收件人: "seata/seata"<seata@noreply.github.com>;
抄送: "FUNKYE"<364176773@qq.com>;"Comment"<comment@noreply.github.com>;
主题: Re: [seata/seata] feature: spring boot support for custom config and registry type (#3198)
|
`registry { custom { This is possible as long as your dependency is seata-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please add configuration information to the configuration file in |
Codecov Report
@@ Coverage Diff @@
## develop #3198 +/- ##
==========================================
Coverage 50.50% 50.51%
- Complexity 3135 3139 +4
==========================================
Files 596 598 +2
Lines 19761 19773 +12
Branches 2465 2465
==========================================
+ Hits 9980 9988 +8
- Misses 8777 8781 +4
Partials 1004 1004
|
@wangliang181230 Configuration information added to the configuration file in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Add the Spring Boot support for custom config and registry type
Ⅱ. Does this pull request fix one issue?
Fixes #3196.
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews