Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize rpc message when message was substring #3200

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

optimize rpc message when message was substring

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #3200 into develop will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3200      +/-   ##
=============================================
- Coverage      50.51%   50.50%   -0.02%     
+ Complexity      3137     3135       -2     
=============================================
  Files            596      596              
  Lines          19761    19761              
  Branches        2465     2465              
=============================================
- Hits            9982     9980       -2     
  Misses          8777     8777              
- Partials        1002     1004       +2     
Impacted Files Coverage Δ Complexity Δ
...zer/seata/protocol/AbstractResultMessageCodec.java 75.00% <0.00%> (ø) 5.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 82.43% <0.00%> (-0.46%) 70.00% <0.00%> (-1.00%)

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/serializer serializer module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants