Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix can not get boolean value in configuration #3205

Merged
merged 4 commits into from
Oct 20, 2020

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Oct 19, 2020

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #2982

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added the module/config config module label Oct 19, 2020
@funky-eyes funky-eyes added this to the 1.4.0 milestone Oct 19, 2020
@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #3205 into develop will increase coverage by 0.00%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3205   +/-   ##
==========================================
  Coverage      50.95%   50.95%           
- Complexity      3205     3207    +2     
==========================================
  Files            602      602           
  Lines          19815    19817    +2     
  Branches        2470     2472    +2     
==========================================
+ Hits           10096    10098    +2     
  Misses          8707     8707           
  Partials        1012     1012           
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/config/FileConfiguration.java 34.81% <62.50%> (-0.53%) 7.00 <0.00> (ø)
...in/java/io/seata/server/session/GlobalSession.java 83.18% <0.00%> (+0.45%) 71.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 55.15% <0.00%> (+0.51%) 29.00% <0.00%> (+1.00%)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 changed the title bugfix: boolean cannot be case to string bugfix: fix can not get boolean value in configuration Oct 20, 2020
@l81893521 l81893521 merged commit fc3640a into apache:develop Oct 20, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/config config module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

io.seata.config.FileConfiguration: fileListener execute error:null
5 participants