-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the 'RootContext.DEFAULT_BRANCH_TYPE' is wrong in some cases #3214
Merged
xingfudeshi
merged 7 commits into
apache:develop
from
wangliang181230:bugfix-SeataProperties-invalid-for-ConfigurationFactory
Oct 23, 2020
Merged
bugfix: fix the 'RootContext.DEFAULT_BRANCH_TYPE' is wrong in some cases #3214
xingfudeshi
merged 7 commits into
apache:develop
from
wangliang181230:bugfix-SeataProperties-invalid-for-ConfigurationFactory
Oct 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangliang181230
changed the title
bugfix: XA automatic proxy does not work in some cases
bugfix: fix the 'RootContext.DEFAULT_BRANCH_TYPE' is wrong in some cases
Oct 22, 2020
Codecov Report
@@ Coverage Diff @@
## develop #3214 +/- ##
=============================================
- Coverage 51.05% 51.04% -0.02%
Complexity 3258 3258
=============================================
Files 609 609
Lines 20023 20027 +4
Branches 2499 2501 +2
=============================================
Hits 10222 10222
- Misses 8784 8787 +3
- Partials 1017 1018 +1
|
wangliang181230
added
module/core
core module
type: bug
Category issues or prs related to bug.
labels
Oct 23, 2020
funky-eyes
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xingfudeshi
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
wangliang181230
deleted the
bugfix-SeataProperties-invalid-for-ConfigurationFactory
branch
October 23, 2020 05:34
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
bugfix: fix the
RootContext.DEFAULT_BRANCH_TYPE
is wrong in some cases.修复BUG:在部分情况下,
RootContext.DEFAULT_BRANCH_TYPE
的值有误。Cases:
@EnableAutoDataSourceProxy
启用XA自动代理。(这种情况下,XA代理不生效)RootContext.DEFAULT_BRANCH_TYPE
却是AT
)Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews