optimize: optimize fileListener to decrease cpu time usage #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caohdgege
changed the title
funky-eyes
requested changes
Oct 26, 2020
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Outdated
Show resolved
Hide resolved
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #3222 +/- ##
=============================================
- Coverage 51.08% 51.08% -0.01%
+ Complexity 3275 3273 -2
=============================================
Files 612 612
Lines 20057 20063 +6
Branches 2501 2504 +3
=============================================
+ Hits 10246 10249 +3
Misses 8792 8792
- Partials 1019 1022 +3
|
funky-eyes
requested changes
Oct 27, 2020
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Outdated
Show resolved
Hide resolved
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Show resolved
Hide resolved
slievrly
reviewed
Oct 28, 2020
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Outdated
Show resolved
Hide resolved
…ton' into optimize-use-fileListener-singleton
slievrly
changed the title
slievrly
changed the title
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
由原来的每个dataId, configurationListener对应一个FileListener的死循环
改成所有的FileListener就对应一个死循环
Ⅱ. Does this pull request fix one issue?
fixes #3571
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews