Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix Collections NPE #3233

Merged
merged 2 commits into from
Oct 28, 2020
Merged

bugfix: fix Collections NPE #3233

merged 2 commits into from
Oct 28, 2020

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Oct 28, 2020

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: fix Collections NPE

Ⅱ. Does this pull request fix one issue?

fix #3234

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #3233 into develop will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3233      +/-   ##
=============================================
- Coverage      51.09%   51.09%   -0.01%     
- Complexity      3279     3281       +2     
=============================================
  Files            612      612              
  Lines          20082    20088       +6     
  Branches        2507     2508       +1     
=============================================
+ Hits           10261    10264       +3     
- Misses          8800     8802       +2     
- Partials        1021     1022       +1     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/SessionHolder.java 50.86% <60.00%> (-0.05%) 22.00 <0.00> (ø)
...rce/sql/struct/cache/PostgresqlTableMetaCache.java 75.58% <100.00%> (ø) 10.00 <0.00> (ø)

@slievrly slievrly added this to the 1.4.0 milestone Oct 28, 2020
@slievrly slievrly merged commit 1e08c03 into apache:develop Oct 28, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collections NPE
4 participants