-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:add deflater support for seata compressor. #3238
Conversation
plz add enum in CompressorType |
Hi @caohdgege I fix it, Thanks. |
Codecov Report
@@ Coverage Diff @@
## develop #3238 +/- ##
=============================================
+ Coverage 51.02% 51.08% +0.05%
- Complexity 3279 3290 +11
=============================================
Files 612 614 +2
Lines 20112 20147 +35
Branches 2517 2520 +3
=============================================
+ Hits 10263 10292 +29
- Misses 8820 8826 +6
Partials 1029 1029
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #3232 .
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews