Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature:add deflater support for seata compressor. #3238

Merged
merged 9 commits into from
Nov 22, 2020

Conversation

dongzl
Copy link
Contributor

@dongzl dongzl commented Oct 29, 2020

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #3232 .

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@caohdgege
Copy link
Contributor

plz add enum in CompressorType

@dongzl
Copy link
Contributor Author

dongzl commented Oct 29, 2020

plz add enum in CompressorType

Hi @caohdgege I fix it, Thanks.

@codecov-io
Copy link

codecov-io commented Nov 2, 2020

Codecov Report

Merging #3238 into develop will increase coverage by 0.05%.
The diff coverage is 77.77%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3238      +/-   ##
=============================================
+ Coverage      51.02%   51.08%   +0.05%     
- Complexity      3279     3290      +11     
=============================================
  Files            612      614       +2     
  Lines          20112    20147      +35     
  Branches        2517     2520       +3     
=============================================
+ Hits           10263    10292      +29     
- Misses          8820     8826       +6     
  Partials        1029     1029              
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/core/compressor/CompressorType.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/io/seata/compressor/deflater/DeflaterUtil.java 80.64% <80.64%> (ø) 6.00 <6.00> (?)
.../seata/compressor/deflater/DeflaterCompressor.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...in/java/io/seata/server/session/GlobalSession.java 83.18% <0.00%> (+0.45%) 71.00% <0.00%> (+1.00%)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leizhiyuan leizhiyuan self-requested a review November 15, 2020 00:14
Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 45f7a88 into apache:develop Nov 22, 2020
LiWenGu pushed a commit to LiWenGu/seata that referenced this pull request Dec 4, 2020
@slievrly slievrly added this to the 1.5.0 milestone Dec 8, 2020
@wangliang181230 wangliang181230 modified the milestones: 1.5.0, 1.4.1 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deflater compressor support for seata-compressor module.
8 participants