bugfix: forbidden use order by or limit in multi sql #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3241 +/- ##
=============================================
+ Coverage 51.54% 51.56% +0.01%
- Complexity 3337 3341 +4
=============================================
Files 616 616
Lines 20233 20243 +10
Branches 2535 2541 +6
=============================================
+ Hits 10430 10439 +9
+ Misses 8753 8752 -1
- Partials 1050 1052 +2
|
jsbxyyx
reviewed
Nov 16, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/exec/MultiDeleteExecutor.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/exec/MultiDeleteExecutor.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/exec/MultiUpdateExecutor.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/exec/MultiUpdateExecutor.java
Outdated
Show resolved
Hide resolved
caohdgege
force-pushed
the
bugfix-1030
branch
from
ae282c4
to
860b6c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
if multi sql contains order by or limit, throws NotSupportYetException to notic user
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews