Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix batch sql getTableMeta error #3242

Merged
merged 2 commits into from
Oct 30, 2020
Merged

bugfix: fix batch sql getTableMeta error #3242

merged 2 commits into from
Oct 30, 2020

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Oct 29, 2020

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: fix batch sql getTableMeta error

Ⅱ. Does this pull request fix one issue?

fix #3244

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@wangliang181230 wangliang181230 added this to the 1.4.0 milestone Oct 30, 2020
Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Oct 30, 2020

Codecov Report

Merging #3242 into develop will decrease coverage by 0.03%.
The diff coverage is 7.69%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3242      +/-   ##
=============================================
- Coverage      51.09%   51.05%   -0.04%     
  Complexity      3279     3279              
=============================================
  Files            612      612              
  Lines          20088    20100      +12     
  Branches        2509     2513       +4     
=============================================
- Hits           10264    10263       -1     
- Misses          8802     8812      +10     
- Partials        1022     1025       +3     
Impacted Files Coverage Δ Complexity Δ
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 61.01% <7.69%> (-13.46%) 13.00 <4.00> (+2.00) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 82.72% <0.00%> (-0.46%) 70.00% <0.00%> (-1.00%)

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 49f1b5d into apache:develop Oct 30, 2020
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch sql getTableMeta error
6 participants