optimize: change client.log.exceptionRate to log.exceptionRate #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
approved these changes
Nov 2, 2020
funky-eyes
added
first-time contributor
Codecov Report
@@ Coverage Diff @@
## develop #3247 +/- ##
=============================================
- Coverage 50.88% 50.86% -0.02%
+ Complexity 3281 3278 -3
=============================================
Files 612 612
Lines 20113 20113
Branches 2519 2519
=============================================
- Hits 10235 10231 -4
- Misses 8852 8853 +1
- Partials 1026 1029 +3
|
ls9527
changed the title
caohdgege
suggested changes
Nov 6, 2020
There was a problem hiding this comment.
plz change LogProperties, otherwise seata could not read config from yml
&& plz change application.properties, config.txt, application.yml
需要修改一下LogProperties这个类，不然的话seata是没办法从yml(properties)文件读取配置，
同时需要把application.properties, config.txt, application.yml里面的配置项也对应修改一下
caohdgege
reviewed
Nov 6, 2020
script/client/conf/file.conf
Outdated
| @@ -66,7 +66,7 @@ client { | |||
| logSerialization = "jackson" | |||
| logTable = "undo_log" | |||
| } | |||
| log { | |||
| } | |||
| log { | |||
| exceptionRate = 100 | |||
There was a problem hiding this comment.
缩进改了， idea 的默认对其他类型的配置文件是4个空格的缩进。
可以通过加入 .editorconfig 配置文件， 对java,properties,yml.conf 等后缀的缩进排版统一。
如果这种事情发生的比较多， 就可以考虑一下。
反正idea能直接导出.editorconfig 文件， 在做一点点修改就可以了
| @@ -151,7 +151,7 @@ | |||
| "defaultValue": true | |||
| }, | |||
| { | |||
| "name": "seata.client.log.exception-rate", | |||
| "name": "seata.log.exception-rate", | |||
| "type": "java.lang.Integer", | |||
| "sourceType": "io.seata.spring.boot.autoconfigure.properties.client.LogProperties", | |||
…te_1101 # Conflicts: # seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/StarterConstants.java
caohdgege
reviewed
Nov 22, 2020
caohdgege
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
StackTraceLogger 打印的debug,info,error 日志会根据配置 client.log.exceptionRate 随机打印错误栈。
事实上info 日志在 rm, warn日志在tm, error 日志在tc. 所以 client 的前缀就不准确。 希望去掉client前缀
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews