Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: clear the listener map of zk registry #3254

Merged
merged 4 commits into from
Nov 25, 2020

Conversation

ls9527
Copy link
Contributor

@ls9527 ls9527 commented Nov 2, 2020

Ⅰ. Describe what this PR did

在恢复之前清除监听器映射, 否则每次调用恢复, 会倒是监听器的映射翻倍。

就一句代码, 水个PR

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Nov 2, 2020

Codecov Report

Merging #3254 (6eb1bbd) into develop (be83b1e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3254      +/-   ##
=============================================
- Coverage      50.87%   50.87%   -0.01%     
- Complexity      3280     3281       +1     
=============================================
  Files            612      612              
  Lines          20113    20114       +1     
  Branches        2519     2518       -1     
=============================================
  Hits           10233    10233              
  Misses          8853     8853              
- Partials        1027     1028       +1     
Impacted Files Coverage Δ Complexity Δ
...very/registry/zk/ZookeeperRegisterServiceImpl.java 60.46% <0.00%> (-0.48%) 26.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 82.72% <0.00%> (-0.46%) 70.00% <0.00%> (-1.00%)
...torage/file/store/FileTransactionStoreManager.java 57.41% <0.00%> (+0.64%) 29.00% <0.00%> (+1.00%)

@funky-eyes funky-eyes added this to the 1.5.0 milestone Nov 10, 2020
@funky-eyes funky-eyes added first-time contributor first-time contributor module/discovery discovery module labels Nov 10, 2020
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 19eb9aa into apache:develop Nov 25, 2020
LiWenGu pushed a commit to LiWenGu/seata that referenced this pull request Dec 4, 2020
@wangliang181230 wangliang181230 modified the milestones: 1.5.0, 1.4.1 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/discovery discovery module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants