bugfix: fix AsyncWorker potential OOM problem #3258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3258 +/- ##
=============================================
+ Coverage 51.44% 51.56% +0.11%
- Complexity 3327 3329 +2
=============================================
Files 616 616
Lines 20206 20192 -14
Branches 2536 2529 -7
=============================================
+ Hits 10395 10412 +17
+ Misses 8766 8736 -30
+ Partials 1045 1044 -1
|
ls9527
approved these changes
Nov 6, 2020
ls9527
approved these changes
Nov 7, 2020
xingfudeshi
reviewed
Nov 11, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/AsyncWorker.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Nov 11, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/AsyncWorker.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Nov 11, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/AsyncWorker.java
Outdated
Show resolved
Hide resolved
caohdgege
reviewed
Nov 15, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/AsyncWorker.java
Outdated
Show resolved
Hide resolved
caohdgege
reviewed
Nov 15, 2020
| DataSourceManager resourceManager = (DataSourceManager) DefaultResourceManager.get().getResourceManager(BranchType.AT); | ||
| DataSourceProxy dataSourceProxy = resourceManager.get(resourceId); | ||
| if (dataSourceProxy == null) { | ||
| LOGGER.warn("Failed to find resource for {}", resourceId); |
There was a problem hiding this comment.
这里是不是应该直接抛出异常？而不是打了日志之后return？
There was a problem hiding this comment.
这里应该不能抛出异常， 抛出异常的话for循环处理就中断了。
在多数据源的场景下，第一个数据源找不到影响第二个数据源无法提交也不合理。
是不是搞个大catch，让这个dealWithGroupedContexts不抛出异常比较好？
There was a problem hiding this comment.
大而全地catch的话，不好区分异常发生的地方(以便针对性地输出日志)
jsbxyyx
reviewed
Dec 15, 2020
jsbxyyx
reviewed
Dec 15, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/AsyncWorker.java
Outdated
Show resolved
Hide resolved
jsbxyyx
reviewed
Dec 15, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/AsyncWorker.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Fix AsyncWorker may cause OOM when TC continuously send async commit message to RM.
Ⅱ. Does this pull request fix one issue?
fixes #3240
Ⅳ. Describe how to verify it
use method descripted in the issue.