optimize: use PriorityQueue to simply ShutdownHook #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3260 +/- ##
=============================================
+ Coverage 50.91% 51.12% +0.20%
- Complexity 3288 3295 +7
=============================================
Files 614 614
Lines 20148 20125 -23
Branches 2522 2514 -8
=============================================
+ Hits 10259 10288 +29
+ Misses 8859 8805 -54
- Partials 1030 1032 +2
|
funky-eyes
reviewed
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Use PriorityQueue to replace TreeSet, so that ShutdownHook's logic could be more clearlly and simple.