Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: delete unnecessary @Sharable #3319

Merged
merged 1 commit into from
Dec 5, 2020
Merged

optimize: delete unnecessary @Sharable #3319

merged 1 commit into from
Dec 5, 2020

Conversation

suichen
Copy link
Contributor

@suichen suichen commented Nov 30, 2020

RmNettyRemotingClient/TmNettyRemotingClient do not used in pipeline, so can remove @sharable

funky-eyes
funky-eyes approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes
Copy link
Contributor

Please add optimize: before the title

@suichen suichen changed the title delete unnecessary @Sharable optimize: delete unnecessary @Sharable Nov 30, 2020
l81893521
l81893521 approved these changes Dec 5, 2020
View reviewed changes
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 added this to the 1.5.0 milestone Dec 5, 2020
slievrly
slievrly approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 709c43f into apache:develop Dec 5, 2020
@suichen suichen deleted the netty_fix branch December 5, 2020 14:38
@wangliang181230 wangliang181230 modified the milestones: 1.5.0, 1.4.1 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l81893521 l81893521 l81893521 approved these changes

@slievrly slievrly slievrly approved these changes

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees
No one assigned
Labels
module/core core module waitting-to-merge
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@suichen @funky-eyes @l81893521 @slievrly @wangliang181230