bugfix: fix retry commit unsuccess when record subMachineInst failed #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
long187
reviewed
Dec 8, 2020
| throw new ForwardInvalidException( | ||
| "Cannot find sub statemachine [" + subStateMachine.getStateMachineName() + "]", | ||
| FrameworkErrorCode.ObjectNotExists); | ||
| return startNewStateMachine(startParams, engine, stateInstance, subStateMachine); |
There was a problem hiding this comment.
Need to use originalStateInst
There was a problem hiding this comment.
fixed, use originalStateInst instead
long187
requested review from
slievrly,
long187,
funky-eyes and
wangliang181230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix: 当子状态机实例创建失败后，修复找不到上一次子状态机实例，导致重试一直失败问题
Ⅱ. Does this pull request fix one issue?
fixes #3324
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews