Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: adjust GlobalLockTemplateTest #3345

Merged
merged 2 commits into from
Dec 8, 2020
Merged

optimize: adjust GlobalLockTemplateTest #3345

merged 2 commits into from
Dec 8, 2020

Conversation

selfishlover
Copy link
Contributor

Ⅰ. Describe what this PR did

adjust GlobalLockTemplateTest logic, make it more stable when ci.

@selfishlover selfishlover changed the title adjust test optimize: adjust GlobalLockTemplateTest Dec 8, 2020
@anselleeyy
Copy link
Contributor

单元测试运行失败，是不是在这里: io.seata.rm.datasource.exec.LockRetryControllerTest，增添一个 @AfterEach 来 remove GlobalLockConfigHolder 更好点？

@selfishlover
Copy link
Contributor Author

单元测试运行失败，是不是在这里: io.seata.rm.datasource.exec.LockRetryControllerTest，增添一个 @AfterEach 来 remove GlobalLockConfigHolder 更好点？

嗯，我把那个测试类也清一波。

long187
long187 approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@long187 long187 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xingfudeshi
xingfudeshi approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 3e50fe5 into apache:develop Dec 8, 2020
@selfishlover selfishlover deleted the fix-GlobalLockTemplateTest branch December 8, 2020 05:59
@wangliang181230 wangliang181230 added this to the 1.5.0 milestone Dec 9, 2020
slievrly
slievrly reviewed Dec 9, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230 wangliang181230 modified the milestones: 1.5.0, 1.4.1 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly left review comments

@long187 long187 long187 approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

@funky-eyes funky-eyes Awaiting requested review from funky-eyes

@wangliang181230 wangliang181230 Awaiting requested review from wangliang181230

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@selfishlover @anselleeyy @long187 @slievrly @xingfudeshi @wangliang181230