Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix throw IllegalArgumentException when using hystrix and version 2.2.3.RELEASE and below of SCA #3351

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Dec 9, 2020

Ⅰ. Describe what this PR did

bugfix: fix throw IllegalArgumentException when using hystrix and version 2.2.3.RELEASE and below of SCA.
修复使用hystrixSCA 2.2.3.RELEASE及以下版本时抛出IllegalArgumentException异常的问题。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@wangliang181230 wangliang181230 changed the title bugfix: fix throw IllegalArgumentException when using hystrix and SCA 2.2.3.RELEASE and below bugfix: fix throw IllegalArgumentException when using hystrix and version 2.2.3.RELEASE and below of SCA Dec 9, 2020
Copy link
Contributor

@long187 long187 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit f0711ad into apache:develop Dec 9, 2020
@wangliang181230 wangliang181230 added this to the 1.5.0 milestone Dec 9, 2020
@wangliang181230 wangliang181230 deleted the bugfix-histrix branch December 9, 2020 03:47
@wangliang181230 wangliang181230 modified the milestones: 1.5.0, 1.4.1 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants