feature: Saga support customize whether update last retry log #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3372 +/- ##
=============================================
- Coverage 51.58% 51.57% -0.02%
- Complexity 3333 3340 +7
=============================================
Files 616 616
Lines 20198 20233 +35
Branches 2531 2535 +4
=============================================
+ Hits 10420 10435 +15
- Misses 8734 8751 +17
- Partials 1044 1047 +3
|
…e_persist_retryInst_log
…e_persist_retryInst_log
long187
suggested changes
Dec 17, 2020
...aga-engine-store/src/main/java/io/seata/saga/engine/store/db/DbAndReportTcStateLogStore.java
Outdated
Show resolved
Hide resolved
...aga-engine-store/src/main/java/io/seata/saga/engine/store/db/DbAndReportTcStateLogStore.java
Outdated
Show resolved
Hide resolved
long187
suggested changes
Dec 21, 2020
...aga-engine-store/src/main/java/io/seata/saga/engine/store/db/DbAndReportTcStateLogStore.java
Outdated
Show resolved
Hide resolved
long187
requested review from
long187,
wangliang181230,
slievrly and
funky-eyes
anselleeyy
changed the title
saga/seata-saga-engine-store/src/main/java/io/seata/saga/engine/store/db/StateLogStoreSqls.java
Outdated
Show resolved
Hide resolved
long187
suggested changes
Dec 22, 2020
...seata-saga-statelang/src/main/java/io/seata/saga/statelang/domain/impl/StateMachineImpl.java
Outdated
Show resolved
Hide resolved
...seata-saga-statelang/src/main/java/io/seata/saga/statelang/domain/impl/StateMachineImpl.java
Outdated
Show resolved
Hide resolved
...pring-boot-starter/src/main/resources/META-INF/additional-spring-configuration-metadata.json
Outdated
Show resolved
Hide resolved
...pring-boot-starter/src/main/resources/META-INF/additional-spring-configuration-metadata.json
Outdated
Show resolved
Hide resolved
saga/seata-saga-statelang/src/main/java/io/seata/saga/statelang/domain/StateMachine.java
Outdated
Show resolved
Hide resolved
saga/seata-saga-statelang/src/main/java/io/seata/saga/statelang/domain/ServiceTaskState.java
Outdated
Show resolved
Hide resolved
...aga-engine-store/src/main/java/io/seata/saga/engine/store/db/DbAndReportTcStateLogStore.java
Outdated
Show resolved
Hide resolved
anselleeyy
force-pushed
the
feature/customize_persist_retryInst_log
branch
from
80444c2
to
ce7e216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
add config for saga, support customize whether update last retry log
提供配置，可自定义正向重试和反向补偿重试的日志存储策略，支持在上一次重试日志的基础上，做更新操作
提供全局配置参数：client.rm.sagaRetryPersistModeUpdate、client.rm.sagaCompensatePersistModeUpdate，默认为 false
提供状态机级别、单个状态节点配置参数：retryPersistModeUpdate、compensatePersistModeUpdate，默认为 false
当 client.rm.sagaRetryPersistModeUpdate 或 retryPersistModeUpdate 配置为true时，当前事务节点的重试，基于当前需要重试的事务日志做更新，而不是新增一条重试日志（compensate 参数同理）
Ⅱ. Does this pull request fix one issue?
fixes #3394
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews