Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test case for tmClient #3381

Merged
merged 4 commits into from
Dec 23, 2020
Merged

test: test case for tmClient #3381

merged 4 commits into from
Dec 23, 2020

Conversation

Ifdevil
Copy link
Contributor

@Ifdevil Ifdevil commented Dec 16, 2020

Ⅰ. Describe what this PR did

test: test case for tmClient

Ⅱ. Does this pull request fix one issue?

fix #194

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xingfudeshi xingfudeshi added the first-time contributor first-time contributor label Dec 17, 2020
xingfudeshi
xingfudeshi reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment.

Ifdevil
Ifdevil commented Dec 22, 2020
View reviewed changes
Copy link
Contributor Author

@Ifdevil Ifdevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please correct any errors that you find

slievrly
slievrly reviewed Dec 22, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any copyright header?

@codecov-io
Copy link

codecov-io commented Dec 22, 2020 •
edited

Codecov Report

Merging #3381 (272584b) into develop (aeeda42) will increase coverage by 0.21%.
The diff coverage is 78.04%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3381      +/-   ##
=============================================
+ Coverage      51.26%   51.47%   +0.21%     
- Complexity      3318     3334      +16     
=============================================
  Files            616      616              
  Lines          20174    20172       -2     
  Branches        2517     2484      -33     
=============================================
+ Hits           10342    10384      +42     
+ Misses          8795     8723      -72     
- Partials        1037     1065      +28
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/seata/config/ConfigurationCache.java 66.66% <78.04%> (+21.66%) 11.00 <0.00> (+1.00)
...java/io/seata/rm/datasource/DataSourceManager.java 24.39% <0.00%> (-10.31%) 4.00% <0.00%> (-3.00%)
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) 3.00% <0.00%> (ø%)
...otobuf/convertor/BranchReportRequestConvertor.java 90.90% <0.00%> (-9.10%) 3.00% <0.00%> (ø%)
...obuf/convertor/BranchRollbackRequestConvertor.java 92.00% <0.00%> (-8.00%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0.00%> (-7.41%) 3.00% <0.00%> (ø%)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) 11.00% <0.00%> (-1.00%)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
... and 39 more

funky-eyes
funky-eyes approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caohdgege
caohdgege reviewed Dec 23, 2020
View reviewed changes
tm/src/test/java/io/seata/tm/TMClientTest.java
import org.junit.jupiter.api.Test;

/**
* test for tmClient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加一下@author ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,done

caohdgege
caohdgege approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xingfudeshi
xingfudeshi approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 2598b16 into apache:develop Dec 23, 2020
@slievrly slievrly added this to the 1.5.0 milestone Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly left review comments

@funky-eyes funky-eyes funky-eyes approved these changes

@caohdgege caohdgege caohdgege approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees
No one assigned
Labels
first-time contributor first-time contributor
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

Add unit test to fescar-tm module
6 participants
@Ifdevil @codecov-io @slievrly @funky-eyes @caohdgege @xingfudeshi