Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize StatementProxyTest unit test #3383

Merged

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #3383 (f6cff68) into develop (5d4c991) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3383   +/-   ##
==========================================
  Coverage      51.55%   51.55%           
  Complexity      3329     3329           
==========================================
  Files            616      616           
  Lines          20198    20198           
  Branches        2531     2531           
==========================================
  Hits           10413    10413           
  Misses          8739     8739           
  Partials        1046     1046           

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 2bd39c9 into apache:develop Dec 22, 2020
@slievrly slievrly added this to the 1.5.0 milestone Dec 24, 2020
@l81893521 l81893521 deleted the optimize_prepared_statement_proxy_test branch April 22, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants