-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add distributed lock interface #3427
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3427 +/- ##
=============================================
+ Coverage 51.54% 51.56% +0.02%
- Complexity 3364 3376 +12
=============================================
Files 617 618 +1
Lines 20419 20441 +22
Branches 2560 2565 +5
=============================================
+ Hits 10524 10540 +16
- Misses 8837 8841 +4
- Partials 1058 1060 +2
|
/** | ||
* The constant UNDOLOG_DELETE | ||
*/ | ||
String UNDOLOG_DELETE = "UndoLogDelete"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UndologDelete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, need to further define how to load different lock implementations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews