Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add distributed lock interface #3427

Merged
merged 8 commits into from
Jan 8, 2021
Merged

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 31, 2020

Codecov Report

Merging #3427 (b2d58c7) into develop (aebaaff) will increase coverage by 0.02%.
The diff coverage is 52.38%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3427      +/-   ##
=============================================
+ Coverage      51.54%   51.56%   +0.02%     
- Complexity      3364     3376      +12     
=============================================
  Files            617      618       +1     
  Lines          20419    20441      +22     
  Branches        2560     2565       +5     
=============================================
+ Hits           10524    10540      +16     
- Misses          8837     8841       +4     
- Partials        1058     1060       +2     
Impacted Files Coverage Δ Complexity Δ
...ommon/src/main/java/io/seata/common/Constants.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.41% <40.00%> (-0.23%) 29.00 <4.00> (+1.00) ⬇️
...in/java/io/seata/server/session/SessionHolder.java 53.17% <80.00%> (+2.31%) 30.00 <8.00> (+8.00)
...n/java/io/seata/server/session/SessionManager.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...in/java/io/seata/server/session/GlobalSession.java 84.09% <0.00%> (+0.45%) 72.00% <0.00%> (+1.00%)

@funky-eyes funky-eyes added this to the 1.5.0 milestone Dec 31, 2020
@funky-eyes funky-eyes added the module/server server module label Dec 31, 2020
/**
* The constant UNDOLOG_DELETE
*/
String UNDOLOG_DELETE = "UndoLogDelete";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UndologDelete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to further define how to load different lock implementations

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit c65aec5 into apache:develop Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants