optimize:optimize the auto-configuration processing of starter #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3441 +/- ##
=============================================
- Coverage 51.57% 51.56% -0.01%
+ Complexity 3376 3374 -2
=============================================
Files 617 619 +2
Lines 20467 20468 +1
Branches 2564 2564
=============================================
- Hits 10555 10554 -1
Misses 8852 8852
- Partials 1060 1062 +2
|
slievrly
reviewed
Jan 6, 2021
...t-starter/src/main/java/io/seata/spring/boot/autoconfigure/SeataPropertiesConfiguration.java
Outdated
Show resolved
Hide resolved
...t-starter/src/main/java/io/seata/spring/boot/autoconfigure/SeataDataSourceConfiguration.java
Outdated
Show resolved
Hide resolved
...t-starter/src/main/java/io/seata/spring/boot/autoconfigure/SeataPropertiesConfiguration.java
Outdated
Show resolved
Hide resolved
…e_auto_configuration � Conflicts: � changes/1.5.0.md � changes/en-us/1.5.0.md � seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/SeataAutoConfiguration.java
...arter/src/main/java/io/seata/spring/boot/autoconfigure/SeataDataSourceAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...arter/src/main/java/io/seata/spring/boot/autoconfigure/SeataPropertiesAutoConfiguration.java
Outdated
Show resolved
Hide resolved
funky-eyes
added
module/seata-spring-boot-starter
…e_auto_configuration � Conflicts: � changes/1.5.0.md � changes/en-us/1.5.0.md
...arter/src/main/java/io/seata/spring/boot/autoconfigure/SeataDataSourceAutoConfiguration.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
The current implementation of seata auto-confuguration does not seem good.The PR does a optimization of it.
Ⅱ. Does this pull request fix one issue?
fixes #3440
Ⅲ. Why don't you add test cases (unit test/integration test)?
I have tested it with spring-boot-mybatis
Ⅳ. Describe how to verify it
Please test it with seata-samples(spring-boot-mybatis).
Ⅴ. Special notes for reviews