-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: put the xid and branchId into the MDC #3447
Merged
xingfudeshi
merged 49 commits into
apache:develop
from
wangliang181230:optimize/logback-add-xid
Jan 22, 2021
Merged
optimize: put the xid and branchId into the MDC #3447
xingfudeshi
merged 49 commits into
apache:develop
from
wangliang181230:optimize/logback-add-xid
Jan 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caohdgege
reviewed
Jan 6, 2021
Codecov Report
@@ Coverage Diff @@
## develop #3447 +/- ##
=============================================
+ Coverage 51.54% 51.56% +0.02%
- Complexity 3376 3385 +9
=============================================
Files 617 619 +2
Lines 20474 20522 +48
Branches 2567 2563 -4
=============================================
+ Hits 10553 10582 +29
- Misses 8861 8879 +18
- Partials 1060 1061 +1 |
slievrly
reviewed
Jan 7, 2021
server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java
Show resolved
Hide resolved
slievrly
reviewed
Jan 12, 2021
server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java
Show resolved
Hide resolved
slievrly
reviewed
Jan 13, 2021
server/src/main/java/io/seata/server/session/SessionHelper.java
Outdated
Show resolved
Hide resolved
slievrly
approved these changes
Jan 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xingfudeshi
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize: put the xid and branchId into the MDC
优化:将xid和branchId放入MDC中,能够通过xid找到与全局事务相关的所有日志。
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews