Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: put the xid and branchId into the MDC #3447

Merged
merged 49 commits into from
Jan 22, 2021

Conversation

wangliang181230
Copy link
Contributor

Ⅰ. Describe what this PR did

optimize: put the xid and branchId into the MDC
优化:将xid和branchId放入MDC中,能够通过xid找到与全局事务相关的所有日志。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #3447 (30c6b60) into develop (ded2c83) will increase coverage by 0.02%.
The diff coverage is 55.17%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3447      +/-   ##
=============================================
+ Coverage      51.54%   51.56%   +0.02%     
- Complexity      3376     3385       +9     
=============================================
  Files            617      619       +2     
  Lines          20474    20522      +48     
  Branches        2567     2563       -4     
=============================================
+ Hits           10553    10582      +29     
- Misses          8861     8879      +18     
- Partials        1060     1061       +1     
Impacted Files Coverage Δ Complexity Δ
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 14.76% <0.00%> (ø) 5.00 <0.00> (ø)
...ging/logback/appender/EnhancedLogstashEncoder.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...c/main/java/io/seata/core/context/RootContext.java 48.27% <36.36%> (+1.10%) 19.00 <0.00> (+1.00)
...o/seata/server/coordinator/DefaultCoordinator.java 53.30% <47.61%> (-1.11%) 29.00 <2.00> (ø)
...eata/server/storage/file/lock/FileLockManager.java 81.81% <50.00%> (+4.04%) 4.00 <0.00> (ø)
...java/io/seata/tm/api/DefaultGlobalTransaction.java 65.71% <50.00%> (+0.32%) 23.00 <1.00> (ø)
.../java/io/seata/server/coordinator/DefaultCore.java 49.70% <66.66%> (+1.51%) 26.00 <0.00> (+2.00)
...torage/file/store/FileTransactionStoreManager.java 57.05% <66.66%> (-0.37%) 28.00 <0.00> (-1.00)
...in/java/io/seata/server/session/SessionHelper.java 71.69% <87.50%> (+6.83%) 14.00 <6.00> (+6.00)
...java/io/seata/server/coordinator/AbstractCore.java 54.54% <100.00%> (+0.52%) 12.00 <0.00> (ø)
... and 4 more

@slievrly
Copy link
Member

image

@wangliang181230
Copy link
Contributor Author

wangliang181230 commented Jan 11, 2021

image

done

@wangliang181230 wangliang181230 added this to the 1.5.0 milestone Jan 14, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi self-requested a review January 22, 2021 05:08
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 381d60b into apache:develop Jan 22, 2021
@wangliang181230 wangliang181230 deleted the optimize/logback-add-xid branch January 22, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants