optimize: remove duplicate validAddress code #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3459 +/- ##
==========================================
Coverage 51.56% 51.57%
- Complexity 3373 3377 +4
==========================================
Files 617 617
Lines 20438 20438
Branches 2565 2564 -1
==========================================
+ Hits 10538 10540 +2
Misses 8839 8839
+ Partials 1061 1059 -2
|
funky-eyes
approved these changes
Jan 9, 2021
funky-eyes
added
module/discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
移除
NacosRegistryServiceImpl类中重复的validAddress方法，保持和其他RegistryService实现一样，使用NetUtil.validAddress方法。Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews