Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix test case NPE and StackTraceLogger's log #3464

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Jan 13, 2021

Ⅰ. Describe what this PR did

bugfix: fix test case NPE and StackTraceLogger's log.

BUG修复:

  1. 修复测试用例空指针异常。
  2. 修正StackTraceLogger中错误的日志格式。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@wangliang181230 wangliang181230 changed the title bugfix: fix test case and StackTraceLogger's log bugfix: fix test case NPE and StackTraceLogger's log Jan 14, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit ded2c83 into apache:develop Jan 14, 2021
@wangliang181230 wangliang181230 deleted the bugfix/fix-test-case branch January 14, 2021 04:47
@wangliang181230 wangliang181230 added this to the 1.5.0 milestone Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants