feature: support RedisLocker#acquireLock use LUA mode #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3472 +/- ##
=============================================
- Coverage 52.09% 51.76% -0.33%
+ Complexity 3498 3484 -14
=============================================
Files 637 638 +1
Lines 21105 21154 +49
Branches 2618 2619 +1
=============================================
- Hits 10994 10951 -43
- Misses 9025 9117 +92
Partials 1086 1086
|
funky-eyes
reviewed
Jan 19, 2021
| sb.append(" end "); | ||
| sb.append("for i =1, keySize do "); | ||
| sb.append(" if(array[i] == 'no') then "); | ||
| sb.append("redis.call('HSET',KEYS[i],'").append(XID).append("',ARGV[(i-1)*7+4]);"); |
There was a problem hiding this comment.
please optimize the string as a constant
litianyu1992
changed the title
…acquireLock # Conflicts: # server/src/main/java/io/seata/server/storage/redis/lock/RedisLocker.java
funky-eyes
reviewed
Feb 19, 2021
| } catch (IOException e) { | ||
| return; | ||
| } | ||
| ACQUIRE_LOCK_SHA = jedis.scriptLoad(acquireLockLuaByFile.toString()); |
There was a problem hiding this comment.
try (Jedis jedis = JedisPooledFactory.getJedisInstance()) { 放到这比较合适，避免压根文件不存在时还创建一个连接
| if (ACQUIRE_LOCK_SHA == null) { | ||
| try (Jedis jedis = JedisPooledFactory.getJedisInstance()) { | ||
| File luaFile = FileLoader.load(REDIS_LUA_FILE_NAME); | ||
| if (luaFile != null) { |
There was a problem hiding this comment.
建议增加日志明确目前竞争锁走的是lua还是pipeline
litianyu1992
changed the title
…into optimize_redislock#acquireLock
# Conflicts: # changes/1.5.0.md
slievrly
reviewed
Feb 23, 2021
| args.add(needLockXid); | ||
| for (LockDO lockDO : needLockDOs) { | ||
| keys.add(buildLockKey(lockDO.getRowKey())); | ||
| args.add(lockDO.getXid()); |
slievrly
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #3472 +/- ##
=============================================
+ Coverage 51.89% 51.97% +0.07%
+ Complexity 3537 3506 -31
=============================================
Files 639 639
Lines 21414 21183 -231
Branches 2664 2627 -37
=============================================
- Hits 11113 11010 -103
+ Misses 9193 9082 -111
+ Partials 1108 1091 -17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Use Lua to ensure atomicity
Ⅱ. Does this pull request fix one issue?
no
Ⅲ. Why don't you add test cases (unit test/integration test)?
jedis mock not support jedis.eval
Ⅳ. Describe how to verify it
acquireLock
Ⅴ. Special notes for reviews