-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add transaction service group for metric #3486
Conversation
plz deal with the ci exception |
Codecov Report
@@ Coverage Diff @@
## develop #3486 +/- ##
=============================================
- Coverage 51.61% 51.60% -0.01%
+ Complexity 3392 3383 -9
=============================================
Files 621 621
Lines 20528 20545 +17
Branches 2558 2560 +2
=============================================
+ Hits 10595 10602 +7
- Misses 8874 8880 +6
- Partials 1059 1063 +4 |
麻烦把没有没改动就进行了代码格式化的地方还原一下,这样有利于只关注你真正改动的地方进行code review |
all seems good |
This reverts commit b4d7eb2.
目前就只格式化了涉及修改的代码行,因为代码超长格式化后出现了断行导致冲突较多 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
请在changes文件夹中的2个md文件进行登记pr信息和作者信息 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Add transaction service group for metric.
Ⅱ. Does this pull request fix one issue?
feature#3471
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews