Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add transaction service group for metric #3486

Merged
merged 8 commits into from
Feb 4, 2021

Conversation

xuande
Copy link
Contributor

@xuande xuande commented Jan 23, 2021

Ⅰ. Describe what this PR did

Add transaction service group for metric.

Ⅱ. Does this pull request fix one issue?

feature#3471

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@caohdgege
Copy link
Contributor

plz deal with the ci exception

@codecov-io
Copy link

codecov-io commented Jan 23, 2021

Codecov Report

Merging #3486 (18d013a) into develop (b503ce6) will decrease coverage by 0.00%.
The diff coverage is 68.51%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3486      +/-   ##
=============================================
- Coverage      51.61%   51.60%   -0.01%     
+ Complexity      3392     3383       -9     
=============================================
  Files            621      621              
  Lines          20528    20545      +17     
  Branches        2558     2560       +2     
=============================================
+ Hits           10595    10602       +7     
- Misses          8874     8880       +6     
- Partials        1059     1063       +4     
Impacted Files Coverage Δ Complexity Δ
...va/io/seata/core/event/GlobalTransactionEvent.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 53.05% <50.00%> (-0.26%) 28.00 <2.00> (-1.00)
.../java/io/seata/server/coordinator/DefaultCore.java 51.13% <62.50%> (+1.42%) 26.00 <4.00> (ø)
...ava/io/seata/server/metrics/MetricsSubscriber.java 79.03% <76.92%> (+0.30%) 7.00 <4.00> (ø)
...on/src/main/java/io/seata/common/util/NetUtil.java 45.83% <0.00%> (-6.07%) 14.00% <0.00%> (-4.00%)
...erver/storage/file/session/FileSessionManager.java 51.82% <0.00%> (-5.11%) 26.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/SessionHolder.java 53.17% <0.00%> (-3.18%) 30.00% <0.00%> (-4.00%)
...torage/file/store/FileTransactionStoreManager.java 57.05% <0.00%> (-0.65%) 28.00% <0.00%> (-1.00%)
...rage/redis/store/RedisTransactionStoreManager.java 63.92% <0.00%> (-0.46%) 37.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 83.63% <0.00%> (-0.46%) 71.00% <0.00%> (-1.00%)
... and 7 more

@funky-eyes
Copy link
Contributor

麻烦把没有没改动就进行了代码格式化的地方还原一下,这样有利于只关注你真正改动的地方进行code review

@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 24, 2021
@funky-eyes funky-eyes added first-time contributor first-time contributor module/server server module labels Jan 24, 2021
@spilledyear
Copy link
Contributor

all seems good

@xuande
Copy link
Contributor Author

xuande commented Jan 25, 2021

麻烦把没有没改动就进行了代码格式化的地方还原一下,这样有利于只关注你真正改动的地方进行code review

目前就只格式化了涉及修改的代码行,因为代码超长格式化后出现了断行导致冲突较多

Copy link
Contributor

@zhengyangyong zhengyangyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes
Copy link
Contributor

请在changes文件夹中的2个md文件进行登记pr信息和作者信息

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 092718b into apache:develop Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/server server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants