Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix typo #3491

Merged
merged 1 commit into from
Jan 26, 2021
Merged

optimize: fix typo #3491

merged 1 commit into from
Jan 26, 2021

Conversation

cznc
Copy link
Contributor

@cznc cznc commented Jan 26, 2021

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

Merging #3491 (32ffe71) into develop (77a340e) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3491      +/-   ##
=============================================
- Coverage      51.59%   51.57%   -0.03%     
+ Complexity      3386     3383       -3     
=============================================
  Files            621      621              
  Lines          20522    20522              
  Branches        2560     2560              
=============================================
- Hits           10589    10584       -5     
- Misses          8873     8875       +2     
- Partials        1060     1063       +3     
Impacted Files Coverage Δ Complexity Δ
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) 11.00% <0.00%> (-1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 52.83% <0.00%> (-0.48%) 28.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 83.63% <0.00%> (-0.46%) 71.00% <0.00%> (-1.00%)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . the prefix add optimize:

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title a word of spelling error optimize: fix typo Jan 26, 2021
@slievrly slievrly merged commit 4104898 into apache:develop Jan 26, 2021
@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants