Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize release savepoint when use oracle #3523

Merged
merged 2 commits into from
Feb 20, 2021
Merged

optimize: optimize release savepoint when use oracle #3523

merged 2 commits into from
Feb 20, 2021

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize: optimize release savepoint when use oracle

Ⅱ. Does this pull request fix one issue?

fix #2794

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Feb 18, 2021

Codecov Report

Merging #3523 (1deb585) into develop (fa3791e) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3523      +/-   ##
=============================================
- Coverage      51.58%   51.57%   -0.02%     
+ Complexity      3401     3398       -3     
=============================================
  Files            621      621              
  Lines          20655    20655              
  Branches        2579     2580       +1     
=============================================
- Hits           10655    10652       -3     
- Misses          8933     8934       +1     
- Partials        1067     1069       +2     
Impacted Files Coverage Δ Complexity Δ
...ta/rm/datasource/exec/SelectForUpdateExecutor.java 81.25% <25.00%> (ø) 10.00 <0.00> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) 11.00% <0.00%> (-1.00%)

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes
Copy link
Contributor

changes 1.5.0.md

@l81893521 l81893521 merged commit 26910a3 into apache:develop Feb 20, 2021
@slievrly slievrly added this to the 1.5.0 milestone Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oracle使用select for update提示:oracle does not support release save point, but this is not a error.
5 participants