Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize the memory footprint of redis mode #3528

Merged
merged 24 commits into from
May 8, 2021

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #3526

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Feb 20, 2021

Codecov Report

Merging #3528 (43f4406) into develop (6400385) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3528      +/-   ##
=============================================
- Coverage      52.09%   52.07%   -0.02%     
- Complexity      3498     3500       +2     
=============================================
  Files            637      637              
  Lines          21105    21113       +8     
  Branches        2618     2618              
=============================================
+ Hits           10994    10995       +1     
- Misses          9025     9030       +5     
- Partials        1086     1088       +2     
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/core/store/BranchTransactionDO.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rage/redis/store/RedisTransactionStoreManager.java 64.15% <80.76%> (-0.23%) 39.00 <5.00> (+1.00) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) 11.00% <0.00%> (-1.00%)

@funky-eyes funky-eyes added this to the 1.5.0 milestone Feb 21, 2021
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly modified the milestones: 1.4.2, 1.5.0 Mar 29, 2021
@funky-eyes
Copy link
Contributor Author

@ph3636 @lightClouds917 PTAL

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2021

Codecov Report

Merging #3528 (8fe8665) into develop (1ab63ea) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3528      +/-   ##
=============================================
- Coverage      51.89%   51.88%   -0.01%     
- Complexity      3533     3534       +1     
=============================================
  Files            639      639              
  Lines          21408    21414       +6     
  Branches        2665     2665              
=============================================
+ Hits           11109    11110       +1     
- Misses          9190     9195       +5     
  Partials        1109     1109              
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/core/store/BranchTransactionDO.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ata/rm/datasource/undo/AbstractUndoLogManager.java 51.42% <0.00%> (ø) 19.00 <0.00> (ø)
...in/java/io/seata/server/session/GlobalSession.java 83.47% <80.00%> (+0.43%) 76.00 <0.00> (+1.00)
...rage/redis/store/RedisTransactionStoreManager.java 64.15% <80.76%> (-0.23%) 39.00 <5.00> (+1.00) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 52.58% <100.00%> (+0.02%) 28.00 <0.00> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) 11.00% <0.00%> (-1.00%)

Copy link
Contributor

@ph3636 ph3636 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, vote for @ph3636

@funky-eyes funky-eyes merged commit 500b464 into apache:develop May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

不停的fullGc,导致服务无响应
6 participants