-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize the memory footprint of redis mode #3528
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3528 +/- ##
=============================================
- Coverage 52.09% 52.07% -0.02%
- Complexity 3498 3500 +2
=============================================
Files 637 637
Lines 21105 21113 +8
Branches 2618 2618
=============================================
+ Hits 10994 10995 +1
- Misses 9025 9030 +5
- Partials 1086 1088 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@ph3636 @lightClouds917 PTAL |
Codecov Report
@@ Coverage Diff @@
## develop #3528 +/- ##
=============================================
- Coverage 51.89% 51.88% -0.01%
- Complexity 3533 3534 +1
=============================================
Files 639 639
Lines 21408 21414 +6
Branches 2665 2665
=============================================
+ Hits 11109 11110 +1
- Misses 9190 9195 +5
Partials 1109 1109
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, vote for @ph3636
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #3526
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews