-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize the get pks by auto when auto generated keys is false #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm-datasource/src/main/java/io/seata/rm/datasource/exec/mysql/MySQLInsertExecutor.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/test/java/io/seata/rm/datasource/exec/MySQLInsertExecutorTest.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #3544 +/- ##
==========================================
Coverage 51.94% 51.94%
+ Complexity 3485 3484 -1
==========================================
Files 637 637
Lines 21079 21105 +26
Branches 2609 2614 +5
==========================================
+ Hits 10949 10963 +14
- Misses 9049 9057 +8
- Partials 1081 1085 +4
|
slievrly
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xingfudeshi
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
MySQL插入的时候,如果getGeneratedKeys无法获取到主键,并且是批量插入的时候,原本的逻辑只能回滚第一条插入的数据,参考MySQL的jdbc驱动的StatementImpl的实现,在业务层进行自增长,保证回滚的时候可以回滚全部的数据。
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews